tfoman/devops-directive-docker-course
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add newlines to end Dockerfiles

Browse Source
This commit is contained in:
sid palas
2023-02-10 10:37:13 -05:00
parent f8dda04c6f
commit 9001f31036
20 changed files with 18 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
06-building-container-images/api-node/Dockerfile.7
View File

@ -30,7 +30,3 @@ COPY --chown=node:node ./src/ .
EXPOSE 3000 EXPOSE 3000
CMD [ "node", "index.js" ] CMD [ "node", "index.js" ]
# TODO: Use multi-stage with distroless image or chainguard image?
# https://github.com/GoogleContainerTools/distroless/blob/main/examples/nodejs/Dockerfile
# https://edu.chainguard.dev/chainguard/chainguard-images/reference/node/overview/

4
06-building-container-images/api-node/Dockerfile.8
View File

@ -33,7 +33,3 @@ COPY --chown=node:node ./src/ .
EXPOSE 3000 EXPOSE 3000
CMD [ "node", "index.js" ] CMD [ "node", "index.js" ]
# TODO: Use multi-stage with distroless image or chainguard image?
# https://github.com/GoogleContainerTools/distroless/blob/main/examples/nodejs/Dockerfile
# https://edu.chainguard.dev/chainguard/chainguard-images/reference/node/overview/

2
06-building-container-images/client-react/Dockerfile.4
View File

@ -24,5 +24,3 @@ COPY nginx.conf /etc/nginx/conf.d/default.conf
COPY --from=build usr/src/app/dist/ /usr/share/nginx/html COPY --from=build usr/src/app/dist/ /usr/share/nginx/html
EXPOSE 80 EXPOSE 80
# No CMD specified... will uses CMD/ENTRYPOINT from base image (nginx:1.23-alpine)

2
06-building-container-images/client-react/Dockerfile.5
View File

@ -27,5 +27,3 @@ COPY --link nginx.conf /etc/nginx/conf.d/default.conf
COPY --link --from=build usr/src/app/dist/ /usr/share/nginx/html COPY --link --from=build usr/src/app/dist/ /usr/share/nginx/html
EXPOSE 80 EXPOSE 80
# No CMD specified... will uses CMD/ENTRYPOINT from base image (nginx:1.23-alpine)